Conversation
github-actions
bot
added
A-minifier
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
There was a problem hiding this comment.
Pull Request Overview
This PR enhances the minifier's side-effect analysis by marking more global constructors as side-effect free. The changes improve the test infrastructure and extend the list of built-in constructors that are considered safe to optimize away when they don't have observable side effects.
- Replaces manual global variable tracking with the
javascript-globalslibrary for more comprehensive coverage - Adds side-effect free handling for built-in constructors like
Set,Map,Boolean,Error, etc. - Refactors test utilities to use static string references instead of owned
Stringvalues
Reviewed Changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
crates/oxc_minifier/tests/ecmascript/may_have_side_effects.rs |
Updates test infrastructure to use javascript-globals and adds comprehensive tests for new expression side effects |
crates/oxc_minifier/Cargo.toml |
Adds dependency on javascript-globals library |
crates/oxc_ecmascript/src/side_effects/may_have_side_effects.rs |
Implements side-effect free handling for built-in global constructors |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
CodSpeed Instrumentation Performance ReportMerging #13082 will not alter performanceComparing Summary
|
Boshen
deleted the
08-14-feat_minifier_mark_more_global_constructors_as_side-effect_free
branch
No description provided.